Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for parsing enums with the @ParseEnum macro, refactors test structure to use nested suites, and fixes a typo in an error message. The changes enable binary parsing of enum types with various matching strategies.
Key Changes
- Added
@ParseEnummacro with associated@match,@matchAndTake, and@matchDefaultmacros for enum case parsing - Refactored existing utility functions into shared
Constants.swiftandUtilities.swiftfiles - Reorganized test files into nested test suites under
BinaryParseKitMacroTests - Fixed spelling error in error message (lietarl → literal)
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/BinaryParseKitMacroTests/Misc.swift | Made test utilities private and added enum macros to test macro specs |
| Tests/BinaryParseKitMacroTests/BinaryParseKitMacroTests.swift | Reorganized struct parsing tests into nested suite extension |
| Tests/BinaryParseKitMacroTests/BinaryParseKitEnumTests.swift | Added comprehensive test cases for enum parsing functionality |
| Sources/BinaryParseKitMacros/Macros/Supports/Utilities.swift | Extracted shared parsing code generation utilities |
| Sources/BinaryParseKitMacros/Macros/Supports/Constants.swift | Centralized package constants and member names |
| Sources/BinaryParseKitMacros/Macros/ParseStruct/*.swift | Updated to use centralized constants and shared utilities |
| Sources/BinaryParseKitMacros/Macros/ParseEnum/*.swift | Implemented new enum parsing macro infrastructure |
| Sources/BinaryParseKit/*.swift | Added enum parsing utilities and updated protocol declarations |
| Package.swift | Added Lifetimes experimental feature |
| .github/workflows/ci.yml | Separated linting into dedicated job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sources/BinaryParseKitMacros/Macros/ParseEnum/EnumCaseParseInfo.swift
Outdated
Show resolved
Hide resolved
Sources/BinaryParseKitMacros/Macros/ParseEnum/ParseEnumMacroError.swift
Outdated
Show resolved
Hide resolved
FlickerSoul
force-pushed
the
dev/enum-parsing
branch
from
a6079e6 to
16f9897
Compare
FlickerSoul
force-pushed
the
dev/enum-parsing
branch
from
16f9897 to
f090d26
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the macro of generating declarative parsing for enums